Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Presentation #5312

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Fix Presentation #5312

merged 1 commit into from
Feb 28, 2024

Conversation

cwfitzgerald
Copy link
Member

@cwfitzgerald cwfitzgerald commented Feb 27, 2024 •
edited
Loading

Connections

Followup to #5244

Description

Just missed two small cases as surfaces aren't currently covered by tests.

Testing

Manually ran the examples.

cc @nical for vis

@cwfitzgerald cwfitzgerald requested a review from a team as a code owner February 27, 2024 21:05
@kaphula kaphula mentioned this pull request Feb 27, 2024
Open
6 tasks
ErichDonGubler
ErichDonGubler approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@ErichDonGubler ErichDonGubler left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems consistent with #5309 (CC @nical EDIT: D'oh, just saw that he was already tagged in the OP. 😅).

@ErichDonGubler ErichDonGubler merged commit 330a860 into gfx-rs:trunk Feb 28, 2024
27 checks passed
@cwfitzgerald cwfitzgerald deleted the fix-presentation branch February 28, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErichDonGubler ErichDonGubler ErichDonGubler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cwfitzgerald @ErichDonGubler