GL actually supports DEPTH32FLOAT_STENCIL8 #5370
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
n/a
Description
Noticed this recently, the GL backend didn't allow the use of
Depth32FloatStencil8
because theDEPTH32FLOAT_STENCIL8
feature isn't claimed to be supported.It actually is supported, so this fixes that and allows for the use of
Depth32FloatStencil8
on GLES/WebGL.Testing
I manually changed the stencil test to use
Depth32FloatStencil8
and it works as expected.The
wgpu_test::clear_texture::clear_texture_depth32_stencil8
test had to be configured to also requirewgpu::DownlevelFlags::DEPTH_TEXTURE_AND_BUFFER_COPIES
as that's not supported on the GLES backend, as otherwise that test tries to now run on GLES but fails.Checklist
cargo fmt
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
--target wasm32-unknown-emscripten
cargo xtask test
to run tests.CHANGELOG.md
. See simple instructions inside file.