fix: add missing deferred resource destruction in Global::poll_all_devices
#5378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nical
approved these changes
Mar 12, 2024
ErichDonGubler
force-pushed
the
missing-deferred-destruction
branch
from
6709341
to
5fe8ed5
Compare
ErichDonGubler
commented
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Description
Describe what problem this is solving, and how it's solved.
#5216
While debugging Firefox's bug 1863872, @jimblandy and @nical discovered with @sotaroikeda's help that
TextureViews appeared to be cleaned up far later than we expected. @nical had recently changed the path of clean-up forTextureViews with deferring until there was no lock contention. That PR added deferred resource clean-up toGlobal::device_poll, but, notably, notGlobal::poll_all_devices, which was certainly intended.With this change, we can no longer reproduce bug 1863872, and we can confirm getting
TextureViewclean-up when we expect it again.Testing
TODO: write testing
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.Add change toCHANGELOG.md. See simple instructions inside file.