-
Notifications
You must be signed in to change notification settings - Fork 948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[naga-cli] Add input-kind
and shader-stage
args
#5411
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is definitely needed functionality! Have some comments about errors and code structure.
7ac8e39
to
e4c8c56
Compare
@cwfitzgerald I believe I have resolved all of your review concerns. This leaves on the table some additional clean-ups regarding existing errors, and replacing them with |
fe9b81c
to
add2b8b
Compare
40b1997
to
7ac8e39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for anyhow is fine, though it may just be easier to switch without needing to build out the anyhow-like infra. Up to you.
Requesting changes as some changes weren't made.
(Reminder: please re-request a review from me once the changes are addressed to make sure I see it!)
7ac8e39
to
502c78c
Compare
Sorry about the branch mixup, this switches it to use anyhow, and should contain the fixes I was referring to previously. What i'd meant previously is that there are further cleanups to existing code that can probably benefit from using anyhow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking a lot better, one more round, then just need a naga person to sign off on it, then we're good to land!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great - going to boop the naga people
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
input-kind
and shader-stage
args
Connections
None
Description
When dealing with .glsl files which have just a plain
.glsl
extension in git.Renaming things such that they include the shader stage can be inconvenient.
This adds an argument
--shader-stage
and uses theFromStr
implementation of that for both extension parsing and command line arguments.This also allows
fragment
,vertex
,compute
to be accepted as well.In addition this also adds
--input-kind
argument which acceptsglsl
, etc...🍀
Testing
Checklist
cargo fmt
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
--target wasm32-unknown-emscripten
cargo xtask test
to run tests.CHANGELOG.md
. See simple instructions inside file.