suspect all the future suspects #5413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robtfm
added a commit
to robtfm/wgpu
that referenced
this pull request
Mar 21, 2024
* suspect all the future suspects * changelog
Wumpf
added a commit
that referenced
this pull request
Mar 23, 2024
* pool tracker vecs * pool * ci * move pool to device * use pool ref, cleanup and comment * suspect all the future suspects (#5413) * suspect all the future suspects * changelog * changelog * review feedback --------- Co-authored-by: Andreas Reich <r_andreas2@web.de>
Wumpf
added
the
PR: needs back-porting
cwfitzgerald
pushed a commit
that referenced
this pull request
Apr 17, 2024
* suspect all the future suspects * changelog
cwfitzgerald
removed
the
PR: needs back-porting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
fixes #5397
Description
buffers/textures with pending writes at user drop time were not taken into the suspected lists for triaging, due to a
take(1)on the iterator.Testing
see the test case from the issue
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.