Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update deno #5469

Merged
merged 12 commits into from
Apr 2, 2024
Merged

chore: update deno #5469

merged 12 commits into from
Apr 2, 2024

Conversation

crowlKats
Copy link
Collaborator

@crowlKats crowlKats commented Apr 1, 2024 •
edited
Loading

Updated #2170

@crowlKats crowlKats requested a review from a team as a code owner April 1, 2024 19:28
littledivy
littledivy approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crowlKats crowlKats marked this pull request as draft April 2, 2024 07:29
@crowlKats
Copy link
Collaborator Author

Blocked on an issue where running files using any of the webgpu related APIs will exit

@crowlKats crowlKats marked this pull request as ready for review April 2, 2024 18:00
@crowlKats
Copy link
Collaborator Author

its fixed now

ErichDonGubler
ErichDonGubler approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@ErichDonGubler ErichDonGubler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving here, qualifying that I only took time to really review dependencies and surface-level checks. I think this is appropriate for how much we actually depend on cts_runner right now, (which, AIUI, is not at all yet).

@ErichDonGubler ErichDonGubler merged commit d828f27 into gfx-rs:trunk Apr 2, 2024
27 checks passed
@crowlKats crowlKats deleted the update-deno branch April 2, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErichDonGubler ErichDonGubler ErichDonGubler approved these changes

@littledivy littledivy littledivy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crowlKats @ErichDonGubler @littledivy