Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hal] Document Api::Fence, its users, and its Vulkan impl. #5618

Merged
merged 2 commits into from
Apr 28, 2024

Conversation

jimblandy
Copy link
Member

No description provided.

@jimblandy jimblandy requested a review from a team as a code owner April 27, 2024 18:48
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all these subtle details 😓 . Appreciate the precise language!

wgpu-hal/src/vulkan/mod.rs Outdated Show resolved Hide resolved
@jimblandy
Copy link
Member Author

Appreciate the precise language!

It's all for naught if it's not actually true! :D

Rename `wgpu_hal::vulkan::Fence::check_active` argument to
`last_completed`, and explain better its rationale.
@jimblandy jimblandy enabled auto-merge (squash) April 28, 2024 05:27
@jimblandy jimblandy merged commit 1ea9639 into gfx-rs:trunk Apr 28, 2024
25 checks passed
@jimblandy jimblandy deleted the hal-doc-fence branch April 29, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants