Fix QuerySet ownership of ComputePass #5671
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
ComputePass
to its parent command encoder #5620RenderPass
make it difficult to use. #1453Part of a series towards lifetime removal on compute passes:
wgpu::ComputePass
) #5432wgpu::ComputePass
methods #5570ComputePass
to its parent command encoder #5620last piece of solving lifetime constraints for
ComputePass
Description
Technically this PR is a bugfix: Previously, when destroying a
QuerySet
that is used in any way (eitherwrite_timestamp
,ComputePassTimestampWrites
orbegin_pipeline_statistics_query
) before executing the pass, we would crash.This solves this as in the PRs before by taking ownership of the query the moment it is provided.
Testing
Adds two new tests that test for gracefully handling destroyed query set before the compute pass is executed.
Both tests failed before the fix.
Checklist
cargo fmt
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
--target wasm32-unknown-emscripten
cargo xtask test
to run tests.CHANGELOG.md
. See simple instructions inside file.