Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove historical comment in rust-toolchain.toml #5728

Merged
merged 1 commit into from
May 22, 2024

Conversation

DJMcNab
Copy link
Contributor

@DJMcNab DJMcNab commented May 22, 2024

Connections
None

Description
A version of rustup which doesn't understand toml-formatted rust-toolchain files won't be looking in rust-toolchain.toml

The file was renamed to rust-toolchain.toml in #4204

rust-toolchain.toml support was added in rustup 1.23, which was released on 2020-11-27, 3 and a half years ago.

Testing
I have confirmed that cargo --version is still 1.76

Checklist

  • Run cargo fmt. N/A
  • Run cargo clippy. If applicable, add: N/A
    • --target wasm32-unknown-unknown N/A
    • --target wasm32-unknown-emscripten N/A
  • Run cargo xtask test to run tests. N/A
  • Add change to CHANGELOG.md. See simple instructions inside file. N/A

A version of rustup which doesn't understand toml-formatted `rust-toolchain` files won't be looking in `rust-toolchain.toml`

The file was renamed to `rust-toolchain.toml` in gfx-rs#4204

rust-toolchain.toml support was added in rustup 1.23, which was released
on 2020-11-27 [1], 3 and a half years ago.

[1]: https://blog.rust-lang.org/2020/11/27/Rustup-1.23.0.html
@DJMcNab DJMcNab requested a review from a team as a code owner May 22, 2024 08:03
rust-toolchain.toml Show resolved Hide resolved
@ErichDonGubler ErichDonGubler merged commit 9f74b15 into gfx-rs:trunk May 22, 2024
25 checks passed
@DJMcNab DJMcNab deleted the tomlchain branch May 22, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants