Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reintroduce computepass->encoder lifetime constraint and make it opt-out via wgpu::ComputePass::forget_lifetime #5768

Merged
merged 8 commits into from
Jun 3, 2024
Merged

Reintroduce computepass->encoder lifetime constraint and make it opt-out via wgpu::ComputePass::forget_lifetime #5768

merged 8 commits into from
Jun 3, 2024

Commits on Jun 2, 2024

  1. Reintroduce computepass->encoder lifetime constraint and make it opt-… 

    …out via `wgpu::ComputePass::make_static`
    @Wumpf
    Wumpf committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    4013682 View commit details
    Browse the repository at this point in the history

  2. improve comments based on review feedback

    @Wumpf
    Wumpf committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    0f0d17f View commit details
    Browse the repository at this point in the history

  3. use the same lifetime name for all usages of ComputePass<'encoder>

    @Wumpf
    Wumpf committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    ba06b26 View commit details
    Browse the repository at this point in the history

  4. comment improvement that I missed earlier

    @Wumpf
    Wumpf committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    df6f891 View commit details
    Browse the repository at this point in the history

  5. more review based comment improvements

    @Wumpf
    Wumpf committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    35d27a7 View commit details
    Browse the repository at this point in the history

  6. use suggested zero-overhead lifetime removal

    @Wumpf
    Wumpf committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    26b5c01 View commit details
    Browse the repository at this point in the history

  7. rename make_static to forge_lifetime

    @Wumpf
    Wumpf committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    7b92817 View commit details
    Browse the repository at this point in the history

  8. missed comma

    @Wumpf
    Wumpf committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    a5bf853 View commit details
    Browse the repository at this point in the history