Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping textures and buffers #67

Merged
merged 3 commits into from
Feb 21, 2019
Merged

Dropping textures and buffers #67

merged 3 commits into from
Feb 21, 2019

Conversation

kvark
Copy link
Member

@kvark kvark commented Feb 21, 2019

No description provided.

@kvark kvark requested a review from grovesNL February 21, 2019 14:15
@kvark
Copy link
Member Author

kvark commented Feb 21, 2019

Alright, I'm going to proceed with this, given that there is stuff piling up on top locally.
@grovesNL I agree that Drop() is slightly controversial. I suggest we keep discussing it and weight things properly - it's easy to switch it back at any point (orthogonal to other pieces of architecture, only related to #68).
bors r+

bors bot added a commit that referenced this pull request Feb 21, 2019
67: Dropping textures and buffers r=kvark a=kvark



Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
@kvark kvark mentioned this pull request Feb 21, 2019
@bors
Copy link
Contributor

bors bot commented Feb 21, 2019

Build succeeded

@bors bors bot merged commit 038e49a into gfx-rs:master Feb 21, 2019
@kvark kvark deleted the drop branch February 21, 2019 18:23
bors bot added a commit that referenced this pull request Feb 22, 2019
69: Swapchain resize r=kvark a=kvark

Based on #67 

Here are the steps (as outlined on Gitter) that this PR follows:
  1. create a dummy frame in the swapchain (`SwapChain::outdated`). We return it when we aren't able to acquire a real frame. No synchronization is done atm, but shouldn't be anything critical there.
  2. handle the errors on acquire and present, use the dummy frame where needed. Presentation errors are just ignored, while acquiring errors are forcing the dummy frame. The idea is that the user would know about a swapchain resize from some kind of event loop / WSI, and thus they'd know when they should actually re-create it.
  3. associate surface with a swapchain. We merge the IDs since there can't be multiple swapchains on the same surface in the near future. Merging simplifies a lot of things in the implementation, but this is to be revised for sure once we get a better look on the browser integration.
  4. when the swapchain is re-created, consume the old one associated with a surface.


Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
mitchmindtree pushed a commit to mitchmindtree/wgpu that referenced this pull request Feb 23, 2020
67: Update to latest wgpu-native commit r=kvark a=rukai

closes gfx-rs/wgpu-rs#66

Make sure my documentation for sample_mask and alpha_to_coverage_enabled is correct, I am not familiar with these fields.

Co-authored-by: Rukai <rubickent@gmail.com>
kvark pushed a commit to kvark/wgpu that referenced this pull request Jun 3, 2021
67: Update to latest wgpu-native commit r=kvark a=rukai

closes gfx-rs/wgpu-rs#66

Make sure my documentation for sample_mask and alpha_to_coverage_enabled is correct, I am not familiar with these fields.

Co-authored-by: Rukai <rubickent@gmail.com>
RandyMcMillan pushed a commit to RandyMcMillan/wgpu that referenced this pull request Jun 19, 2024
Stop emitting private use characters on macOS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant