Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] CLBlast: Fix directory name #1606

Merged
merged 1 commit into from
May 27, 2023
Merged

[CI] CLBlast: Fix directory name #1606

merged 1 commit into from
May 27, 2023

Conversation

SlyEcho
Copy link
Collaborator

@SlyEcho SlyEcho commented May 26, 2023

A recent issue on the CLBlast repo: #479 has caused a new release archive to be created for the same version which has a different file name structure.

Without fixing this the CI will be broken.

In the future, it would probably be better to compile it from source.

@SlyEcho SlyEcho added the build Compilation issues label May 26, 2023
@SlyEcho SlyEcho requested a review from Green-Sky May 26, 2023 23:03
@SlyEcho
Copy link
Collaborator Author

SlyEcho commented May 26, 2023

The result is visible here: https://github.com/SlyEcho/llama.cpp/actions/runs/5095482951/jobs/9160456905 where I am also adding server.exe but it would be a separate PR.

@ghost
Copy link

ghost commented May 27, 2023

I wonder if it would make more sense to just blindly extract the CLBlast release and search for the dll incase they change the name on us again. I came into this issue today preparing a Windows non-AVX2 ClBlast build for a friend.

@SlyEcho
Copy link
Collaborator Author

SlyEcho commented May 27, 2023

It's not just the .dll file, there's CMake files and headers and libraries.

With tar.exe I could use --strip-components to discard whatever directory name is in the archive file, but I didn't see anything similar for 7z.exe. I haven't tested whether tar.exe can extract .7z files, and while it can do .zip files, I have a suspicion that it won't do .7z files.

@Green-Sky Green-Sky changed the title Fix directory name [CI] CLBlast: Fix directory name May 27, 2023
@Green-Sky Green-Sky added the high priority Very important issue label May 27, 2023
@Green-Sky Green-Sky merged commit 83c54e6 into master May 27, 2023
@Green-Sky
Copy link
Collaborator

@SlyEcho something is now up with the otherblas

Copy-Item: D:\a\_temp\cc755b59-caa7-4190-b3d4-bd08115941c4.ps1:6
Line |
   6 |  cp ../LICENSE ./bin/Release/llama.cpp.txt
     |  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | Could not find a part of the path 'D:\a\llama.cpp\llama.cpp\build\bin\Release\llama.cpp.txt'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Compilation issues high priority Very important issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants