Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding git in container package dependencies #1621

Merged
merged 1 commit into from
May 29, 2023

Conversation

jpodivin
Copy link
Contributor

@jpodivin jpodivin commented May 28, 2023

The build-info.sh script is invoking git on lines 6 and 11. However git is not installed by default in ubuntu base images.

This causes an unhandled exception to occur, which is silently passed during the build.

#1626

For example:
https://github.com/ggerganov/llama.cpp/actions/runs/5100538614/jobs/9168878817#step:6:1266
https://github.com/ggerganov/llama.cpp/actions/runs/5100538614/jobs/9168878743#step:6:864

The build-info.sh script is invoking git on lines 6 and 11.
However git is not installed by default in ubuntu base images.

This causes an unhandled exception to occur, which is silently passed
during the build.

Signed-off-by: Jiri Podivin <jpodivin@gmail.com>
@DannyDaemonic
Copy link
Contributor

Good catch. Can you confirm this changes the output from main from main: build = 0 (unknown) to something meaningful?

@jpodivin
Copy link
Contributor Author

Good catch. Can you confirm this changes the output from main from main: build = 0 (unknown) to something meaningful?

Certainly. The original build info from the container:

#ifndef BUILD_INFO_H
#define BUILD_INFO_H

#define BUILD_NUMBER 0
#define BUILD_COMMIT "unknown"

#endif // BUILD_INFO_H

and the one I get from container with this patch:

#ifndef BUILD_INFO_H
#define BUILD_INFO_H

#define BUILD_NUMBER 598
#define BUILD_COMMIT "c01c7d2"

#endif // BUILD_INFO_H

@DannyDaemonic DannyDaemonic merged commit 0e730dd into ggerganov:master May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants