-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only show -ngl option when relevant + other doc/arg handling updates #1625
Only show -ngl option when relevant + other doc/arg handling updates #1625
Conversation
In terms of usability I think any binaries should give you an error message telling you that you need compile option XY to use some feature. An error message that just tells you that some argument doesn't exist is I think much less helpful for users that are unaware of the compilation option even existing. |
You're just talking about display a better error if the user specifies the option that wasn't compiled in, not saying a bunch of detailed information about how to enable it should be added to the edit: How about this? Last commit changes the behavior when using |
Refer to CLBlast and cuBLAS correctly in doc changes.
You're just talking about display a better error if the user specifies the option that wasn't compiled in, not saying a bunch of detailed information about how to enable it should be added to the --help text. Correct? Yes. It's enough to e.g. tell the user that the feature doesn't work because llama.cpp wasn't compiled with cuBLAS/clblast. The user just needs to be told that something is wrong so they'll know to look it up.
I would prefer an error over a warning since people have a tendency not to read warnings but a warning would be fine too - the program just shouldn't silently ignore the CLI argument. |
I can change it if you feel strongly. Otherwise, are you okay with the current behavior? The warning is two lines and the result of ignoring it is also pretty benign: possibly lower performance. |
I don't feel strongly about it. As I said: a warning would be fine too. |
This pull:
LLAMA_SUPPORTS_GPU_OFFLOAD
define tollama.h
(defined when compiled with clBLAST or cuBLAST)-ngl
,--n-gpu-layers
option when GPU offload is possible.-ngl
,--n-gpu-layers
option to themain
andserver
examples documentationmain
andserver
examples documentation to use the new style dash separator argument formatserver
example to use dash separators for its arguments and adds-ngl
to--help
(only shown when compiled with appropriate support). It will still support--memory_f32
and--ctx_size
for compatibility.--memory-f32
for themain
andserver
examples--help
text as well as documentation. Rationale: Is there any perplexity data for using 16bit vs 32bit memory? #1593 (reply in thread)@JohannesGaessler Hopefully this isn't stepping on your toes, I took a different approach to dealing with the GPU offload support issue.
Closes #1555