-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake : support build for iOS/tvOS #3116
Conversation
2669beb
to
1ff4cce
Compare
Great! |
Yeah it might be better and same as other builds, will change it before merge. |
Would it be possible to add VisionOS support as well? |
I've tried an iOS build on visionOS simulator before and it works well. Not yet to try with a visionOS project, but I think it should be easy by add the OS target. |
Thanks! In case you also have a sample Swift/VisionOS project to look at, I'd love to take a look at it too! I tried using |
It was an internal iOS project with target visionOS + Also, if it's a Simulator, during to Metal limitations we can't use constant buffers more than 14, so remember to use ngl = 0. |
@jhen0409 Sorry to have to ask, but where do I set the ngl 0 flag in Swift? I see it as an option in the CI but not anywhere else (e.g. ggml-metal). Thanks for your patience! |
To be clear, it's called |
Fix #3106.
Update the CMakeLists.txt and add CI steps to ensure to continue to work.