metal : support default.metallib load & reuse code for swift package #3522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhen0409
force-pushed
the
metal-lib-load
branch
from
b569ddb
to
f134d64
Compare
jhen0409
changed the title
ggerganov
approved these changes
Oct 7, 2023
joelkuiper
added a commit
to vortext/llama.cpp
that referenced
this pull request
Oct 12, 2023
…example * 'master' of github.com:ggerganov/llama.cpp: py : change version of numpy requirement to 1.24.4 (ggerganov#3515) quantize : fail fast on write errors (ggerganov#3521) metal : support default.metallib load & reuse code for swift package (ggerganov#3522) llm : support Adept Persimmon 8B (ggerganov#3410) Fix for ggerganov#3454 (ggerganov#3455) readme : update models, cuda + ppl instructions (ggerganov#3510) server : docs fix default values and add n_probs (ggerganov#3506)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm doing the same thing as I do in ggerganov/whisper.cpp#1293 (review), this allows it to load compiled default.metallib, and use the source as a fallback.
For easier test by command, we can use
xcrun -sdk macosx metal ggml-metal.metalto compiledefault.metallib, and run./main.I use
SWIFTPM_MODULE_BUNDLEto get bundle for swift package, so we can merge the code on both sides.