Add a check to ensure GIT_INDEX EXISTS before attempting to build build-info.cpp #5256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be better to compute GIT_INDEX correctly rather than just giving up on the build info when it's wrong - it currently works for non-nested submodules and for alternate git worktrees. |
|
Fixes #3902 |
Ok but it would still be good to handle the failure case properly |
|
I think the way it is, it breaks the CI? |
CI? You mean the actions? It shouldn't as all its really doing different is checking a git index exists |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is causing an issue when attempting to build
llama.cppas part of the dart packagellama_cpp_dartwhich i am using for my app maid. I'm encountering some kind of issue where.git/indexcant be found which is likely because maids repo uses nested submodules (maid->llama_cpp_dart->llama.cpp).I understand that this is a pretty rare and obscure issue but it would be really helpful if you could merge this check.