-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON schema conversion: ⚡️ faster repetitions, min/maxLength for strings, cap number length #6555
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
2148f24
json: rename python schema converter to make import easier
ochafik f771a8f
server: skip null json_schema / grammar fields
ochafik 159b883
json: deps management for primitive rules (+ allow null values)
ochafik a59e943
json: optimize repetitions for minItems/maxItems and regexps: `a{,3}`…
ochafik 07163fb
grammars: add troubleshooting section to readme
ochafik dcf5d32
json: cap length of numbers to 15 digits before/after decimal point
ochafik 181f984
json: unify all repetition code (w/ or w/o sep)
ochafik de4e60e
json: support string minLength/maxLength
ochafik 6c885dc
server+json: update server/README w/ result_format
ochafik 3c81e94
nits
ochafik 67a5184
json: fix type error w/ python 3.8
ochafik 9c33ee9
json: fix server/README (json_schema in /completion vs. result_format…
ochafik ed13d47
json: simplify DOT `{"type": "string", "pattern": "^.$"}`
ochafik 958bdda
Merge remote-tracking branch 'origin/master' into json-faster-repetit…
ochafik 64e3059
json: remove recursion in opt_repetitions (avoids Python stack overflow)
ochafik ba90d5b
json: rm dead code
ochafik dfd4eb3
json: rm useless assert & ggml.h import
ochafik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I'm on board with the rename to use underscores -- while there are a few other files with underscores (such as
pydantic_models_to_grammar.py
), most seem to use hyphens (pydantic-models-to-grammar-examples.py
, etc), and it seems like the old filename is possibly better?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Originally I wanted all filenames in the repo to use hyphens. But later I found out that Python does not work well when there are hyphens in the filenames (e.g. I think you cannot include a Python file that has hyphens). So I think it's better to eventually rename all Python files to use underscores in their filenames
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tbh I did all this as a prerequisite for #6389, in which i need to import the converter from Python. I also found out llama-cpp-python inlines that file in their codebase, since it's hard / not trivial to import (short of using importlib, which feels dirty).