Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine original Android sample #1926

Closed
wants to merge 2 commits into from

Conversation

zhouwg
Copy link
Contributor

@zhouwg zhouwg commented Mar 5, 2024

Purpose:

Thanks for original Android sample.
I met some issues when I learned original Android sample at the first time.

This PR is just refine original Android sample code so it's an Android turn-key example and more easily used in Android-based project(pre-study project).

How to practice/play with this PR:

Screenshot_20240305_154128_com litongjava whisper android java

adb logcat | grep WHISPER

Screenshot from 2024-02-23 12-01-00

Attention:
pls using debug version on real Android phone:

Screenshot from 2024-02-23 11-37-47

because there is a confirmed unknown bug(which was not brought by my codes) with release version in original Android sample

Screenshot from 2024-02-23 11-46-44

and I don't know why use complicated third-party binary Android framework in this Android sample.

Screenshot from 2024-02-25 11-56-38

I think "simple is beautiful" just like powerful whisper.cpp's implementation: Plain C/C++ implementation without dependencies .

so I will not spent extra time to fix bug in original Android sample.

@zhouwg zhouwg changed the title Refine original android sample Refine original Android sample Mar 5, 2024
@zhouwg
Copy link
Contributor Author

zhouwg commented Mar 8, 2024

I implemented a very concise implementation of Android example during my on-going PoC.

if it's considered well and accepted, I'll spent time to submit a new PR. so I'd like to close this PR accordingly.

@zhouwg zhouwg closed this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant