Add a new param to set the self attn text context factor #2433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix! Looks good to me. |
|
@aderbedr FYI |
|
Great! This looks good to me. |
|
It's better to avoid the environment variable. Should implement this by adding a |
…rs') Add a param to set the text context factor. No change of behavior: same default (3). Resolve: ggerganov#2334
WilliamTambellini
force-pushed
the
AddTextCtxFactorEnvVar
branch
from
d93ce40
to
3c6f8fc
Compare
|
ok @ggerganov |
WilliamTambellini
changed the title
|
@WilliamTambellini I've pushed an alternative fix. Can you give it a try: #2443 |
|
Superseded by #2443 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an env var to set the text context factor
WHISPER_SELFATTN_CACHE_TEXT_CTX_FACTOR
same default to 3.
Resolve:
#2334