Fixed Beam Search Strategy and exposed whisper_pcm_to_mel_phase_vocoder #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fixes! |
rock3125
pushed a commit
to rock3125/whisper.cpp
that referenced
this pull request
Feb 21, 2023
…hase_vocoder (ggerganov#474) Co-authored-by: Sandro Hanea <sandrohanea@microsoft.com>
anandijain
pushed a commit
to anandijain/whisper.cpp
that referenced
this pull request
Apr 28, 2023
…hase_vocoder (ggerganov#474) Co-authored-by: Sandro Hanea <sandrohanea@microsoft.com>
jacobwu-b
pushed a commit
to jacobwu-b/Transcriptify-by-whisper.cpp
that referenced
this pull request
Oct 24, 2023
…hase_vocoder (ggerganov#474) Co-authored-by: Sandro Hanea <sandrohanea@microsoft.com>
jacobwu-b
pushed a commit
to jacobwu-b/Transcriptify-by-whisper.cpp
that referenced
this pull request
Oct 24, 2023
…hase_vocoder (ggerganov#474) Co-authored-by: Sandro Hanea <sandrohanea@microsoft.com>
landtanin
pushed a commit
to landtanin/whisper.cpp
that referenced
this pull request
Dec 16, 2023
…hase_vocoder (ggerganov#474) Co-authored-by: Sandro Hanea <sandrohanea@microsoft.com>
iThalay
pushed a commit
to iThalay/whisper.cpp
that referenced
this pull request
Sep 23, 2024
…hase_vocoder (ggerganov#474) Co-authored-by: Sandro Hanea <sandrohanea@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses multiple issues.
whisper_full_default_params is not returning the strategy defined in the parameter but the parameters are loaded for that one on line 2966.
Encountered some index out of range during beam search on beam_candidates[cur_c] when all previous decoders have the same sum_logprobs_all. Fixed it with an additional check.
whisper_pcm_to_mel_phase_vocoder is not exposed so it cannot be used to speed up auto-language detection in: Add lang auto-detection in a separate call. sandrohanea/whisper.net#1