-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruby Bindings #500
Ruby Bindings #500
Conversation
That's great! |
@ggerganov thanks, I think I added this into the right place in my most recent push - but I am also now thinking it'd be great to have a ruby gem for people to install easily via One issue with how I am doing a cp to move the whisper.cpp files in extconf.rb is that if we package this into a rubygem those files will need to be in the ruby gem already... I'll work on a spec file now if you think it'd be hepful and maybe overcome this issue. |
@taf2 I added a separate Ruby action based on your commit. I'm not familiar with the ruby ecosystem. Whatever you think would be useful for other people is OK. Regarding the copying of the sources - I don't fully understand why it is necessary. Would be useful to avoid it if possible. |
Agreed - yes I think this is a good starting place for ruby to be merged. I'm going to spend some more time today and hopefully not have to copy those files and maybe recruit some help too for getting it published to rubygems which i think would be ideal. |
* adding ruby bindings * avoid adding these they are copied in via extconf.rb * ignore these files here * add definitions for boolean params * initial transcribe for ruby * use en model and transcribe jfk with assertion * possibly this works for building ruby binding * ci : try to add ruby workflow --------- Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
* adding ruby bindings * avoid adding these they are copied in via extconf.rb * ignore these files here * add definitions for boolean params * initial transcribe for ruby * use en model and transcribe jfk with assertion * possibly this works for building ruby binding * ci : try to add ruby workflow --------- Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
* adding ruby bindings * avoid adding these they are copied in via extconf.rb * ignore these files here * add definitions for boolean params * initial transcribe for ruby * use en model and transcribe jfk with assertion * possibly this works for building ruby binding * ci : try to add ruby workflow --------- Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
* adding ruby bindings * avoid adding these they are copied in via extconf.rb * ignore these files here * add definitions for boolean params * initial transcribe for ruby * use en model and transcribe jfk with assertion * possibly this works for building ruby binding * ci : try to add ruby workflow --------- Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
* adding ruby bindings * avoid adding these they are copied in via extconf.rb * ignore these files here * add definitions for boolean params * initial transcribe for ruby * use en model and transcribe jfk with assertion * possibly this works for building ruby binding * ci : try to add ruby workflow --------- Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
* adding ruby bindings * avoid adding these they are copied in via extconf.rb * ignore these files here * add definitions for boolean params * initial transcribe for ruby * use en model and transcribe jfk with assertion * possibly this works for building ruby binding * ci : try to add ruby workflow --------- Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
I did some work to build a ruby binding with the following interface:
There are no doubt things that could be better and I was not sure how you felt bindings like this should integrate into the rest of the build system. The main thing I was not sure about is I copy when running extconf.rb the source file dependencies needed e.g. whisper.cpp etc...