simplify build #11
Merged
simplify build #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove build.rs for just a standard relative path include.
ggwpez
approved these changes
Dec 22, 2023
There was a problem hiding this comment.
I think it was needed to find the README for cargo publish since that builds the crate on its own outside of the workspace.
Anyway, its probably better to write a small publish.sh that shuffles the files prio to publishing than using a build.rs - i dont like it either 😆
|
Thanks Sergei! |
Merged
ggwpez
added a commit
that referenced
this pull request
Dec 22, 2023
Changes: - Add MAINTAIN.md to explain publishing after #11 - Update deps - Set version to 1.0.1 - Correctly set the workspace.readme key --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
|
Do you mind making a release? Would be really helpful! |
|
Oh sorry, I missed your message above. I wonder if a symbolic link would help. Check out #14 . GH renders it as a file but it's actually a symbolic link (created by ln -s). It seems that the file is packaged properly, but I also saw your other changes now and they also make sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove build.rs for just a standard relative path include.
build scripts are an advanced feature. It just happened that this
particular crate did not play nice with a non-cargo build system.
Likely it would be possible to fix it locally, but I actually don't
see any reason for this crate to have a build.rs
I checked it locally and it seems to produce exactly the same results.
LMK if I am missing something.