Use pytest and ghdl/setup-ghdl-ci #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: RocketRoss <mr@radonn.co.za>
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes some fixes to the docs (suggested by @RocketRoss in #21) and a fix for a warning in a C source.
The main contribution is the addition of a pytest script, instead of listing each example/test explicitly as a separate task in the GitHub Action workflow. Using the pytest script allows finer grained control of which tests are executed/skipped on each platform.
Moreover, Action umarcor/setup-ghdl is used to install latest (nightly) releases of GHDL. See ghdl/ghdl#1315. Instead of replacing existing tasks, four runs are kept:
Currently, setup-ghdl retrieves packages from https://github.com/umarcor/ghdl/releases/tag/nightly. This PR will be kept as a draft untilghdl/ghdl#1315 is merged and setup-ghdl is modified to retrieve packages from https://github.com/ghdl/ghdl/releases/tag/nightly insteadsetup-ghdl is copied to ghdl/setup-ghdl-ci.