Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Developer readme (GSI-696) #4

Merged
merged 4 commits into from
May 24, 2024
Merged

Developer readme (GSI-696) #4

merged 4 commits into from
May 24, 2024

Conversation

TheByronHimes
Copy link
Member

No description provided.

@TheByronHimes TheByronHimes requested a review from mephenor May 22, 2024 13:34
@TheByronHimes TheByronHimes changed the title Developer readme Developer readme (GSI-696) May 22, 2024
mephenor
mephenor requested changes May 23, 2024
View reviewed changes
Copy link
Member

@mephenor mephenor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on the general dev_guide.
There are some smaller phrasing issues and some points that need a bit more discussion, though.

.readme_generation/dev_guide.md Outdated Show resolved Hide resolved
.readme_generation/dev_guide.md Outdated Show resolved Hide resolved
.readme_generation/dev_guide.md Outdated Show resolved Hide resolved
.readme_generation/dev_guide.md Outdated Show resolved Hide resolved
.readme_generation/dev_guide.md Outdated Show resolved Hide resolved
.readme_generation/dev_guide.md Outdated Show resolved Hide resolved
.readme_generation/dev_guide.md Outdated Show resolved Hide resolved
.readme_generation/dev_guide.md Outdated Show resolved Hide resolved
.readme_generation/dev_guide.md Outdated Show resolved Hide resolved
.readme_generation/dev_guide.md Outdated Show resolved Hide resolved
@TheByronHimes
Remove example_data reference
8d60c2e 
Rephrase some things

Add rationale for test dir naming

Remove dockerfile info
@TheByronHimes TheByronHimes requested a review from mephenor May 23, 2024 08:24
@TheByronHimes TheByronHimes merged commit f3757fa into poc_global_deps May 24, 2024
20 of 23 checks passed
@TheByronHimes TheByronHimes deleted the developer_readme branch May 24, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mephenor mephenor mephenor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheByronHimes @mephenor