Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IFRS - Improve file staging error handling (GSI-1190) #75

Merged
merged 7 commits into from
Dec 3, 2024

Conversation

TheByronHimes
Copy link
Member

Bumps ifrs version to 2.1.2

The S3 provider in hexkit already checks to make sure the object doesn't exist in the destination bucket, so I removed the same check from the IFRS -- instead, it will catch the corresponding error, log, and return (same behavior as before).

The potential other errors, listed below, are all logged and re-raised:

  • The object metadata is missing important info like ContentLength
  • The object is over 5 TiB
  • Miscellaneous errors in the boto3 copy/multipart upload operation itself

@TheByronHimes TheByronHimes merged commit 16ecde7 into main Dec 3, 2024
13 checks passed
@TheByronHimes TheByronHimes deleted the ifrs/file_staging_error_handling-GSI-1190 branch December 3, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants