Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps)!: upgrade to Angular 16 #1146

Merged
merged 2 commits into from
May 23, 2023
Merged

feat(deps)!: upgrade to Angular 16 #1146

merged 2 commits into from
May 23, 2023

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented May 23, 2023

  • because ComponentFactoryResolver was removed in Angular 16, we had to replace it with ViewContainerRef and because of this change, the user will have make sure that whenever AngularUtilService is used within any of his Component (like in Example 22), the user will have to provide it via providers: [AngularUtilService]

- because `ComponentFactoryResolver` was removed in Angular 16, we had to replace it with `ViewContainerRef` and because of change, the user will have make sure that whenever `AngularUtilService` is used within a Component (like in Example 22), the user will have provide it via `providers: [AngularUtilService]`
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #1146 (3b207d9) into next (ae46d22) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              next     #1146   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          924       922    -2     
  Branches       306       306           
=========================================
- Hits           924       922    -2     
Impacted Files Coverage Δ
...es/angular-slickgrid/services/container.service.ts 100.00% <ø> (ø)
...angular-slickgrid/extensions/slickRowDetailView.ts 100.00% <100.00%> (ø)
.../angular-slickgrid/services/angularUtil.service.ts 100.00% <100.00%> (ø)

@ghiscoding ghiscoding merged commit f6fb152 into next May 23, 2023
@ghiscoding ghiscoding deleted the feat/angular16 branch May 23, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant