fix(gridMenu): column picker list should include grouped header titles #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add "headerColumnValueExtractor" callback in the global grid options to deal with grouped header titles - also add 2 other new options "contentMinWidth" and "useClickToRepositionMenu" - this requires a new SlickGrid core version with these new options
Codecov Report
@@ Coverage Diff @@
## master #460 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 147 146 -1
Lines 9203 9200 -3
Branches 3058 3186 +128
==========================================
- Hits 9203 9200 -3 Continue to review full report at Codecov.
|
- add few ColumnPicker/GridMenu Cypress E2E tests
ghiscoding
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
blockeduntil a new SlickGrid version2.4.23is released which include the PR