Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(locale): use correct locale text operator tooltip, closes #468 #469

Merged
merged 1 commit into from
May 26, 2020
Merged

fix(locale): use correct locale text operator tooltip, closes #468 #469

merged 1 commit into from
May 26, 2020

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented May 21, 2020 •
edited
Loading

@codecov
Copy link

codecov bot commented May 21, 2020 •
edited
Loading

Codecov Report

Merging #469 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #469    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          148       148            
  Lines         9534      9534            
  Branches      3312      3177   -135     
==========================================
  Hits          9534      9534
Impacted Files Coverage Δ
...s/angular-slickgrid/filters/compoundInputFilter.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4858794...4f8259a. Read the comment docs.

@ghiscoding ghiscoding merged commit d978946 into master May 26, 2020
@ghiscoding ghiscoding deleted the bugfix/compound-filter-wrong-locale branch May 26, 2020 12:47
ghiscoding-SE pushed a commit that referenced this pull request Sep 7, 2021
@ghiscoding
fix(footer): usefix(footer): use getFilteredItemCount to show corre…
fbee1a1 
…ct item count

- fixes Slickgrid-Universal issue [#469](ghiscoding/slickgrid-universal#469)
- we should always use DataView `getFilteredItemCount()` since that is really the item count that we want to show in the footer `getFilteredItemCount` to show correct count, fix #469
- fixes #469
- we should always use DataView `getFilteredItemCount()` since that is really the item count that we want to show in the footer
@ghiscoding ghiscoding mentioned this pull request Sep 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When using Locales, z* shows the tool tip "Contains" in CompoundInputFilter
2 participants
@ghiscoding @ghiscoding-SE