fix: draggable grouping shouldn't throw error when dynamically changi…

…ng columns (#922)

- get latest reorderedColumns on each end event handler

packages/common/src/extensions/slickDraggableGrouping.ts

@@ -279,7 +279,6 @@ export class SlickDraggableGrouping {
    * @param trigger - callback to execute when triggering a column grouping
    */
   setupColumnReorder(grid: SlickGrid, headers: any, _headerColumnWidthDiff: any, setColumns: (columns: Column[]) => void, setupColumnResize: () => void, columns: Column[], getColumnIndex: (columnId: string) => number, uid: string, trigger: (slickEvent: SlickEvent, data?: any) => void) {
-    let reorderedColumns = grid.getColumns();
     const dropzoneElm = grid.getPreHeaderPanel();
     const draggablePlaceholderElm = dropzoneElm.querySelector<HTMLDivElement>('.slick-draggable-dropzone-placeholder');
     const groupTogglerElm = dropzoneElm.querySelector<HTMLDivElement>('.slick-group-toggle-all');
@@ -352,14 +351,14 @@ export class SlickDraggableGrouping {
         }
 
         const finalReorderedColumns: Column[] = [];
+        const reorderedColumns = grid.getColumns();
         for (const reorderedId of reorderedIds) {
           finalReorderedColumns.push(reorderedColumns[getColumnIndex(reorderedId)]);
         }
         setColumns(finalReorderedColumns);
         trigger(grid.onColumnsReordered, { grid });
         e.stopPropagation();
         setupColumnResize();
-        reorderedColumns = finalReorderedColumns;
       }
     } as SortableOptions;
 
@@ -632,4 +631,4 @@ export class SlickDraggableGrouping {
     }
     this.onGroupChanged.notify(args);
   }
-}
+}