Skip to content

Commit

Permalink
fix: only import @excel-builder-vanilla/types for optional dep
Browse files Browse the repository at this point in the history
- since `excel-builder-vanilla` is an optional dependency, we should only import its types, I created a separate types only package to deal with that
  • Loading branch information
ghiscoding committed Aug 29, 2024
1 parent ce8b400 commit 27e983e
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 11 deletions.
2 changes: 1 addition & 1 deletion packages/common/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@
"not dead"
],
"dependencies": {
"@excel-builder-vanilla/types": "^3.0.3",
"@formkit/tempo": "^0.1.2",
"@slickgrid-universal/binding": "workspace:~",
"@slickgrid-universal/event-pub-sub": "workspace:~",
Expand All @@ -74,7 +75,6 @@
"@types/trusted-types": "^2.0.7",
"autocompleter": "^9.3.2",
"dequal": "^2.0.3",
"excel-builder-vanilla": "3.0.1",
"multiple-select-vanilla": "^3.3.2",
"sortablejs": "^1.15.2",
"un-flatten-tree": "^2.0.12",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { ExcelColumnMetadata, ExcelStyleInstruction, StyleSheet } from 'excel-builder-vanilla';
import type { ExcelColumnMetadata, ExcelStyleInstruction, StyleSheet } from '@excel-builder-vanilla/types';

import type { Column } from './column.interface';
import type { GridOption } from './gridOption.interface';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { ExcelStyleInstruction, Worksheet, Workbook } from 'excel-builder-vanilla';
import type { ExcelStyleInstruction, Worksheet, Workbook } from '@excel-builder-vanilla/types';
import type { FileType } from '../enums/fileType.enum';

export interface ExcelExportOption {
Expand Down
2 changes: 1 addition & 1 deletion packages/excel-export/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"dependencies": {
"@slickgrid-universal/common": "workspace:~",
"@slickgrid-universal/utils": "workspace:~",
"excel-builder-vanilla": "^3.0.1"
"excel-builder-vanilla": "^3.0.3"
},
"devDependencies": {
"@slickgrid-universal/event-pub-sub": "workspace:~"
Expand Down
20 changes: 13 additions & 7 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 27e983e

Please sign in to comment.