Skip to content

Commit

Permalink
fix(build): decrease tsc target to es2017 instead of es2020
Browse files Browse the repository at this point in the history
- had too many issues showing up with es2020, possibly because we can't target es5 with it? not sure, we can always come back to a newer version later
  • Loading branch information
ghiscoding committed Jan 28, 2021
1 parent 34baf2c commit 2f2e5f4
Show file tree
Hide file tree
Showing 23 changed files with 44 additions and 44 deletions.
4 changes: 2 additions & 2 deletions packages/common/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"prebundle": "npm-run-all delete:dist",
"postbundle": "npm-run-all sass:build sass:copy",
"bundle:commonjs": "tsc --project tsconfig.build.json --outDir dist/commonjs --module commonjs",
"bundle:esm": "cross-env tsc --project tsconfig.build.json --outDir dist/esm --module esnext --target es2020",
"bundle:esm": "cross-env tsc --project tsconfig.build.json --outDir dist/esm --module esnext --target es2017",
"delete:dist": "cross-env rimraf --maxBusyTries=10 dist",
"package:add-browser-prop": "cross-env node ../change-package-browser.js --add-browser=true --folder-name=common",
"package:remove-browser-prop": "cross-env node ../change-package-browser.js --remove-browser=true --folder-name=common",
Expand Down Expand Up @@ -90,4 +90,4 @@
"node": ">=14.15.0",
"npm": ">=6.14.8"
}
}
}
4 changes: 2 additions & 2 deletions packages/common/tsconfig.build.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
"compilerOptions": {
"module": "esnext",
"moduleResolution": "node",
"target": "es2020",
"target": "es2017",
"lib": [
"es2020",
"es2017",
"dom"
],
"types": [
Expand Down
2 changes: 1 addition & 1 deletion packages/common/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"rootDir": "src",
"declarationDir": "dist/esm",
"outDir": "dist/esm",
"target": "es2020",
"target": "es2017",
"module": "esnext",
"sourceMap": true,
"noImplicitReturns": true,
Expand Down
4 changes: 2 additions & 2 deletions packages/composite-editor-component/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"dev:watch": "run-p build:watch",
"bundle": "run-p bundle:commonjs bundle:esm",
"bundle:commonjs": "tsc --project tsconfig.build.json --outDir dist/commonjs --module commonjs",
"bundle:esm": "cross-env tsc --project tsconfig.build.json --outDir dist/esm --module esnext --target es2020",
"bundle:esm": "cross-env tsc --project tsconfig.build.json --outDir dist/esm --module esnext --target es2017",
"prebundle": "npm-run-all delete:dist",
"delete:dist": "cross-env rimraf --maxBusyTries=10 dist",
"package:add-browser-prop": "cross-env node ../change-package-browser.js --add-browser=true --folder-name=composite-editor-component",
Expand All @@ -47,4 +47,4 @@
"npm-run-all": "^4.1.5",
"rimraf": "^3.0.2"
}
}
}
4 changes: 2 additions & 2 deletions packages/composite-editor-component/tsconfig.build.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
"compilerOptions": {
"module": "esnext",
"moduleResolution": "node",
"target": "es2020",
"target": "es2017",
"lib": [
"es2020",
"es2017",
"dom"
],
"typeRoots": [
Expand Down
4 changes: 2 additions & 2 deletions packages/composite-editor-component/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@
"rootDir": "src",
"declarationDir": "dist/esm",
"outDir": "dist/esm",
"target": "es2020",
"target": "es2017",
"module": "esnext",
"sourceMap": true,
"noImplicitReturns": true,
"lib": [
"es2020",
"es2017",
"dom"
],
"types": [
Expand Down
4 changes: 2 additions & 2 deletions packages/empty-warning-component/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"dev:watch": "run-p build:watch",
"bundle": "run-p bundle:commonjs bundle:esm",
"bundle:commonjs": "tsc --project tsconfig.build.json --outDir dist/commonjs --module commonjs",
"bundle:esm": "cross-env tsc --project tsconfig.build.json --outDir dist/esm --module esnext --target es2020",
"bundle:esm": "cross-env tsc --project tsconfig.build.json --outDir dist/esm --module esnext --target es2017",
"prebundle": "npm-run-all delete:dist",
"delete:dist": "cross-env rimraf --maxBusyTries=10 dist",
"package:add-browser-prop": "cross-env node ../change-package-browser.js --add-browser=true --folder-name=empty-warning-component",
Expand All @@ -47,4 +47,4 @@
"npm-run-all": "^4.1.5",
"rimraf": "^3.0.2"
}
}
}
4 changes: 2 additions & 2 deletions packages/empty-warning-component/tsconfig.build.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
"compilerOptions": {
"module": "esnext",
"moduleResolution": "node",
"target": "es2020",
"target": "es2017",
"lib": [
"es2020",
"es2017",
"dom"
],
"typeRoots": [
Expand Down
4 changes: 2 additions & 2 deletions packages/empty-warning-component/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@
"rootDir": "src",
"declarationDir": "dist/esm",
"outDir": "dist/esm",
"target": "es2020",
"target": "es2017",
"module": "esnext",
"sourceMap": true,
"noImplicitReturns": true,
"lib": [
"es2020",
"es2017",
"dom"
],
"types": [
Expand Down
4 changes: 2 additions & 2 deletions packages/excel-export/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"dev": "run-s build sass:build sass:copy",
"dev:watch": "run-p build:watch",
"bundle:commonjs": "tsc --project tsconfig.build.json --outDir dist/commonjs --module commonjs",
"bundle:esm": "cross-env tsc --project tsconfig.build.json --outDir dist/esm --module esnext --target es2020",
"bundle:esm": "cross-env tsc --project tsconfig.build.json --outDir dist/esm --module esnext --target es2017",
"bundle": "run-p bundle:commonjs bundle:esm",
"prebundle": "npm-run-all delete:dist",
"delete:dist": "cross-env rimraf --maxBusyTries=10 dist",
Expand Down Expand Up @@ -47,4 +47,4 @@
"npm-run-all": "^4.1.5",
"rimraf": "^3.0.2"
}
}
}
4 changes: 2 additions & 2 deletions packages/excel-export/tsconfig.build.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
"compilerOptions": {
"module": "esnext",
"moduleResolution": "node",
"target": "es2020",
"target": "es2017",
"lib": [
"es2020",
"es2017",
"dom"
],
"typeRoots": [
Expand Down
4 changes: 2 additions & 2 deletions packages/excel-export/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@
"rootDir": "src",
"declarationDir": "dist/esm",
"outDir": "dist/esm",
"target": "es2020",
"target": "es2017",
"module": "esnext",
"sourceMap": true,
"noImplicitReturns": true,
"lib": [
"es2020",
"es2017",
"dom"
],
"types": [
Expand Down
4 changes: 2 additions & 2 deletions packages/graphql/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"dev:watch": "run-p build:watch",
"bundle": "run-p bundle:commonjs bundle:esm",
"bundle:commonjs": "tsc --project tsconfig.build.json --outDir dist/commonjs --module commonjs",
"bundle:esm": "cross-env tsc --project tsconfig.build.json --outDir dist/esm --module esnext --target es2020",
"bundle:esm": "cross-env tsc --project tsconfig.build.json --outDir dist/esm --module esnext --target es2017",
"prebundle": "npm-run-all delete:dist",
"delete:dist": "cross-env rimraf --maxBusyTries=10 dist",
"package:add-browser-prop": "cross-env node ../change-package-browser.js --add-browser=true --folder-name=graphql",
Expand All @@ -43,4 +43,4 @@
"devDependencies": {
"moment-mini": "^2.24.0"
}
}
}
4 changes: 2 additions & 2 deletions packages/graphql/tsconfig.build.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
"compilerOptions": {
"module": "esnext",
"moduleResolution": "node",
"target": "es2020",
"target": "es2017",
"lib": [
"es2020",
"es2017",
"dom"
],
"types": [
Expand Down
4 changes: 2 additions & 2 deletions packages/graphql/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@
"rootDir": "src",
"declarationDir": "dist/esm",
"outDir": "dist/esm",
"target": "es2020",
"target": "es2017",
"module": "esnext",
"sourceMap": true,
"noImplicitReturns": true,
"lib": [
"es2020",
"es2017",
"dom"
],
"types": [
Expand Down
4 changes: 2 additions & 2 deletions packages/odata/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"dev:watch": "run-p build:watch",
"bundle": "run-p bundle:commonjs bundle:esm",
"bundle:commonjs": "tsc --project tsconfig.build.json --outDir dist/commonjs --module commonjs",
"bundle:esm": "cross-env tsc --project tsconfig.build.json --outDir dist/esm --module esnext --target es2020",
"bundle:esm": "cross-env tsc --project tsconfig.build.json --outDir dist/esm --module esnext --target es2017",
"prebundle": "npm-run-all delete:dist",
"delete:dist": "cross-env rimraf --maxBusyTries=10 dist",
"package:add-browser-prop": "cross-env node ../change-package-browser.js --add-browser=true --folder-name=odata",
Expand All @@ -40,4 +40,4 @@
"dependencies": {
"@slickgrid-universal/common": "^0.10.0"
}
}
}
4 changes: 2 additions & 2 deletions packages/odata/tsconfig.build.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
"compilerOptions": {
"module": "esnext",
"moduleResolution": "node",
"target": "es2020",
"target": "es2017",
"lib": [
"es2020",
"es2017",
"dom"
],
"types": [
Expand Down
4 changes: 2 additions & 2 deletions packages/odata/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@
"rootDir": "src",
"declarationDir": "dist/esm",
"outDir": "dist/esm",
"target": "es2020",
"target": "es2017",
"module": "esnext",
"sourceMap": true,
"noImplicitReturns": true,
"lib": [
"es2020",
"es2017",
"dom"
],
"types": [
Expand Down
4 changes: 2 additions & 2 deletions packages/text-export/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"dev:watch": "run-p build:watch",
"bundle": "run-p bundle:commonjs bundle:esm",
"bundle:commonjs": "tsc --project tsconfig.build.json --outDir dist/commonjs --module commonjs",
"bundle:esm": "cross-env tsc --project tsconfig.build.json --outDir dist/esm --module esnext --target es2020",
"bundle:esm": "cross-env tsc --project tsconfig.build.json --outDir dist/esm --module esnext --target es2017",
"prebundle": "npm-run-all delete:dist",
"delete:dist": "cross-env rimraf --maxBusyTries=10 dist",
"package:add-browser-prop": "cross-env node ../change-package-browser.js --add-browser=true --folder-name=text-export",
Expand All @@ -47,4 +47,4 @@
"npm-run-all": "^4.1.5",
"rimraf": "^3.0.2"
}
}
}
4 changes: 2 additions & 2 deletions packages/text-export/tsconfig.build.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
"compilerOptions": {
"module": "esnext",
"moduleResolution": "node",
"target": "es2020",
"target": "es2017",
"lib": [
"es2020",
"es2017",
"dom"
],
"types": [
Expand Down
4 changes: 2 additions & 2 deletions packages/text-export/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@
"rootDir": "src",
"declarationDir": "dist/esm",
"outDir": "dist/esm",
"target": "es2020",
"target": "es2017",
"module": "esnext",
"sourceMap": true,
"noImplicitReturns": true,
"lib": [
"es2020",
"es2017",
"dom"
],
"types": [
Expand Down
2 changes: 1 addition & 1 deletion packages/vanilla-bundle/tsconfig.build.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"moduleResolution": "node",
"target": "es2017",
"lib": [
"es2020",
"es2017",
"dom"
],
"typeRoots": [
Expand Down
4 changes: 2 additions & 2 deletions tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
"experimentalDecorators": true,
"esModuleInterop": true,
"module": "commonjs",
"target": "es2020",
"target": "es2017",
"lib": [
"es2020",
"es2017",
"dom"
],
"resolveJsonModule": true
Expand Down

0 comments on commit 2f2e5f4

Please sign in to comment.