fix(common): remove dispose method from container service abstract class

- the `dispose` method should be optional and not always required
ghiscoding · Jul 7, 2022 · 838fc54 · 838fc54
1 parent 5cf5e3d
commit 838fc54
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 8 deletions.
diff --git a/packages/common/src/services/__tests__/container.service.spec.ts b/packages/common/src/services/__tests__/container.service.spec.ts
@@ -5,10 +5,6 @@ describe('Container Service', () => {
     expect(() => ContainerService.prototype.get!('MyService')).toThrow('ContainerService "get" method must be implemented');
   });
 
-  it('should display a not implemented when calling "dispose" method', () => {
-    expect(() => ContainerService.prototype.dispose!()).toThrow('ContainerService "dispose" method must be implemented');
-  });
-
   it('should display a not implemented when calling "registerInstance" method', () => {
     expect(() => ContainerService.prototype.registerInstance('MyService', {})).toThrow('ContainerService "registerInstance" method must be implemented');
   });

diff --git a/packages/common/src/services/container.service.ts b/packages/common/src/services/container.service.ts
@@ -9,10 +9,6 @@ export class ContainerService {
     throw new Error('ContainerService "get" method must be implemented');
   }
 
-  dispose() {
-    throw new Error('ContainerService "dispose" method must be implemented');
-  }
-
   registerInstance(_key: any, _instance: any) {
     throw new Error('ContainerService "registerInstance" method must be implemented');
   }