Skip to content

Commit

Permalink
feat(plugins): move Row Move Manager plugin to universal
Browse files Browse the repository at this point in the history
  • Loading branch information
ghiscoding committed Oct 23, 2021
1 parent cfcfc85 commit b19b2ed
Show file tree
Hide file tree
Showing 36 changed files with 919 additions and 534 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ You might be wondering why was this monorepo created? Here are a few of the reas
The Vanilla Implementation (not associated to any framework) is built with [WebPack](https://webpack.js.org/) and is also used to test all the UI functionalities [Cypress](https://www.cypress.io/) (E2E tests). This [Vanilla bundle](https://github.com/ghiscoding/slickgrid-universal/tree/master/packages/vanilla-bundle) package is also what we use in our SalesForce implementation (with Lightning Web Component), hence the creation of this monorepo library.

### Fully Tested with [Jest](https://jestjs.io/) (Unit Tests) - [Cypress](https://www.cypress.io/) (E2E Tests)
Slickgrid-Universal has **100%** Unit Test Coverage, we are talking about +13,000 lines of code (+3,000 unit tests) that are fully tested with [Jest](https://jestjs.io/). There are also +300 Cypress E2E tests to cover all [Examples](https://ghiscoding.github.io/slickgrid-universal/) and most UI functionalities (there's also an additional +500 tests in Aurelia-Slickgrid)
Slickgrid-Universal has **100%** Unit Test Coverage, we are talking about +15,000 lines of code (+3,700 unit tests) that are fully tested with [Jest](https://jestjs.io/). There are also +400 Cypress E2E tests to cover all [Examples](https://ghiscoding.github.io/slickgrid-universal/) and most UI functionalities (there's also an additional +500 tests in Aurelia-Slickgrid)

### Available Demos

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,7 @@ export class Example7 {
singleRowMove: true,
disableRowSelection: true,
cancelEditOnDrag: true,
hideRowMoveShadow: false,
onBeforeMoveRows: this.onBeforeMoveRow.bind(this),
onMoveRows: this.onMoveRows.bind(this),

Expand Down
3 changes: 2 additions & 1 deletion packages/common/src/enums/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,5 @@ export * from './slickPluginList.enum';
export * from './sortDirection.enum';
export * from './sortDirectionNumber.enum';
export * from './sortDirectionString.type';
export * from './toggleStateChangeType';
export * from './toggleStateChangeType';
export * from './usabilityOverrideFn.type';
2 changes: 1 addition & 1 deletion packages/common/src/enums/slickPluginList.enum.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import {
SlickEditorLock,
SlickGroupItemMetadataProvider,
SlickRowDetailView,
SlickRowMoveManager,
} from '../interfaces/index';
import {
SlickAutoTooltip,
Expand All @@ -16,6 +15,7 @@ import {
SlickDraggableGrouping,
SlickHeaderButtons,
SlickHeaderMenu,
SlickRowMoveManager,
SlickRowSelectionModel,
} from '../plugins/index';

Expand Down
3 changes: 3 additions & 0 deletions packages/common/src/enums/usabilityOverrideFn.type.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import { SlickGrid } from '../interfaces/slickGrid.interface';

export type UsabilityOverrideFn = (row: number, dataContext: any, grid: SlickGrid) => boolean;

This file was deleted.

1 change: 0 additions & 1 deletion packages/common/src/extensions/index.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
export * from './extensionUtility';
export * from './rowDetailViewExtension';
export * from './rowMoveManagerExtension';
Loading

0 comments on commit b19b2ed

Please sign in to comment.