Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): context menu should close when clicking another cell #1163

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

ghiscoding
Copy link
Owner

  • prior to this PR, when opening a context menu in Example 19 and clicking another cell would not close the opened context menu and it should. It seems to be caused by potentially other body mousedown event listeners registered outside of the lib, what we can do is use capture: true to make sure our listener are being dispatched first before other external ones and that fixes our problem.
  • apply this patch to all Menu extensions/plugins

- prior to this PR, when opening a context menu in Example 19 and clicking another cell would not close the opened context menu and it should. It seems to be caused by potentially other body mousedown event listeners registered outside of the lib, what we can do is use `capture: true` to make sure our listener are being dispatched first before other external ones and that fixes our problem.
- apply this patch to all Menu extensions/plugins
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #1163 (13dca50) into master (609f88b) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1163   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          245       245           
  Lines        17166     17166           
  Branches      6196      6196           
=========================================
  Hits         17166     17166           
Files Coverage Δ
packages/common/src/extensions/slickCellMenu.ts 100.00% <100.00%> (ø)
...ackages/common/src/extensions/slickColumnPicker.ts 100.00% <100.00%> (ø)
packages/common/src/extensions/slickContextMenu.ts 100.00% <100.00%> (ø)
packages/common/src/extensions/slickGridMenu.ts 100.00% <100.00%> (ø)
packages/common/src/extensions/slickHeaderMenu.ts 100.00% <100.00%> (ø)

@ghiscoding ghiscoding merged commit bd132c5 into master Oct 30, 2023
5 checks passed
@ghiscoding ghiscoding deleted the bugfix/body-mousedown-use-capture branch October 30, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants