Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(common): context menu should close when clicking another cell #1163

Merged
merged 2 commits into from
Oct 30, 2023
Merged

fix(common): context menu should close when clicking another cell #1163

merged 2 commits into from
Oct 30, 2023

Commits on Oct 30, 2023

  1. fix(common): context menu should close when clicking another cell 

    - prior to this PR, when opening a context menu in Example 19 and clicking another cell would not close the opened context menu and it should. It seems to be caused by potentially other body mousedown event listeners registered outside of the lib, what we can do is use `capture: true` to make sure our listener are being dispatched first before other external ones and that fixes our problem.
- apply this patch to all Menu extensions/plugins
    @ghiscoding-SE
    ghiscoding-SE committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    34bae6c View commit details
    Browse the repository at this point in the history

  2. chore: fix Cypress flaky test

    @ghiscoding-SE
    ghiscoding-SE committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    13dca50 View commit details
    Browse the repository at this point in the history