fix: regression, Row Detail no longer displayed after CSP safe code #1259
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with the CSP safe code implementation, the SlickRowDetail stopped working because it was using a hack. The hack was to using html string and add closing div tag to fall outside the
.slick-cell
but now that we use native HTML element then this hack no longer works. What we can do now is to add an optionalinsertElementAfterTarget
that will provide a way to insert our Row Detail container element after our target which is this case is the.slick-cell
TODOs
before
after
the issue was because we append everything into the
.slick-cell
HTML element inside it but SlickRowDetail was hacking the html string to insert the HTML element after the.slick-cell
. So our new code will simply do it in the correct way viainsertElementAfterTarget
we can see below, the
.dynamic-cell-detail
div is supposed to go after the.slick-cell.l0.r0
but was instead within it which was wrong and causing the regression