Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changing enableCellNavigation grid option not working #1262

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

ghiscoding
Copy link
Owner

  • the previous code had 2 different options and _options that were not always in sync which caused issue when trying to update for example the enableCellNavigation option on the fly. With this new code change, there will no possibility to mix them up anywmore

- the previous code had 2 different `options` and `_options` that were not always in sync which caused issue when trying to update for example the `enableCellNavigation` option on the fly. With this new code change, there will no possibility to mix them up anywmore
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (093e778) 86.66% compared to head (d6c2aed) 86.66%.
Report is 1 commits behind head on next.

Files Patch % Lines
packages/common/src/core/slickGrid.ts 64.29% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1262   +/-   ##
=======================================
  Coverage   86.66%   86.66%           
=======================================
  Files         196      196           
  Lines       21392    21392           
  Branches     7099     7099           
=======================================
  Hits        18538    18538           
  Misses       2854     2854           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit b7de0f1 into next Dec 11, 2023
4 of 5 checks passed
@ghiscoding ghiscoding deleted the bugfix/grid-options-private-prop branch December 11, 2023 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant