Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): use DataView transactions with multiple item changes #14

Merged
merged 3 commits into from
Jul 16, 2020

Conversation

ghiscoding
Copy link
Owner

  • we should use DataView transactions as much as possible when dealing with multiple items (array) in 1 call, that is true for (addItems, deleteItems, updateItems)
    • DataView beginUpdate ... endUpdate

- we should use DataView transactions as much as possible when dealing with multiple items (array) in 1 call, that is true for (addItems, deleteItems, updateItems)
  - DataView `beginUpdate` ...  `endUpdate`
@codecov
Copy link

codecov bot commented Jul 16, 2020

Codecov Report

Merging #14 into master will increase coverage by 0.01%.
The diff coverage is 92.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage   99.58%   99.58%   +0.01%     
==========================================
  Files         184      184              
  Lines        9882     9892      +10     
  Branches     3255     3255              
==========================================
+ Hits         9840     9850      +10     
  Misses         42       42              
Impacted Files Coverage Δ
...bundle/src/components/slick-vanilla-grid-bundle.ts 92.48% <50.00%> (ø)
packages/common/src/extensions/extensionUtility.ts 100.00% <100.00%> (ø)
packages/common/src/services/grid.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 959097c...2630f01. Read the comment docs.

@ghiscoding ghiscoding merged commit 8cbd03a into master Jul 16, 2020
@ghiscoding ghiscoding deleted the feat/dataview-transactions branch July 16, 2020 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants