fix(common): add missing Filter model Type of FilterConstructor
#1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add a `FilterConstructor` type on the `model` prop of a Column filter, this is similar to the recently added `EditorConstructor` type for Editor
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1430 +/- ##
======================================
Coverage 99.8% 99.8%
======================================
Files 199 199
Lines 21614 21614
Branches 7231 7235 +4
======================================
Hits 21550 21550
+ Misses 64 58 -6
- Partials 0 6 +6 ☔ View full report in Codecov by Sentry. |
ghiscoding
added a commit
to ghiscoding/Angular-Slickgrid
that referenced
this pull request
Mar 13, 2024
- the Filter `model` prop should be a constructor and it shouldn't newed (instantiated), it was defined like so in the docs and Wikis but that was actually wrong - ref Slickgrid-Universal [PR 1430](ghiscoding/slickgrid-universal#1430)
ghiscoding
added a commit
to ghiscoding/slickgrid-react
that referenced
this pull request
Mar 13, 2024
- the Filter `model` prop should be a constructor and it shouldn't newed (instantiated), it was defined like so in the docs and Wikis but that was actually wrong - ref Slickgrid-Universal [PR 1430](ghiscoding/slickgrid-universal#1430)
ghiscoding
added a commit
to ghiscoding/aurelia-slickgrid
that referenced
this pull request
Mar 13, 2024
- the Filter `model` prop should be a constructor and it shouldn't newed (instantiated), it was defined like so in the docs and Wikis but that was actually wrong - ref Slickgrid-Universal [PR 1430](ghiscoding/slickgrid-universal#1430)
ghiscoding
added a commit
to ghiscoding/slickgrid-react
that referenced
this pull request
Mar 13, 2024
…#310) - the Filter `model` prop should be a constructor and it shouldn't newed (instantiated), it was defined like so in the docs and Wikis but that was actually wrong - ref Slickgrid-Universal [PR 1430](ghiscoding/slickgrid-universal#1430)
ghiscoding
added a commit
to ghiscoding/aurelia-slickgrid
that referenced
this pull request
Mar 13, 2024
…#1169) - the Filter `model` prop should be a constructor and it shouldn't newed (instantiated), it was defined like so in the docs and Wikis but that was actually wrong - ref Slickgrid-Universal [PR 1430](ghiscoding/slickgrid-universal#1430)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FilterConstructortype on themodelprop of a Column filter, this is similar to the recently addedEditorConstructortype for Editor