Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Grouping): Draggable Grouping cols reorder missing impactedColumns #1557

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Jun 5, 2024

  • Draggable Grouping reimplements enableColumnReorder grid option and also the onColumnsReordered SlickEvent, the later one was missing the impactedColumns argument needed by Slickgrid-Universal to reorder and/or freeze columns

Fixes issue shown in animated gif below

brave_J7i4N0ufOR

Copy link

stackblitz bot commented Jun 5, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@ghiscoding ghiscoding changed the title fix(Grouping): Draggable Grouping cols reorder missing impactedColumns fix(Grouping): Draggable Grouping cols reorder missing impactedColumns Jun 5, 2024
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (9e2dd65) to head (4e378ad).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #1557    +/-   ##
=======================================
  Coverage    99.8%   99.8%            
=======================================
  Files         198     198            
  Lines       21691   21691            
  Branches     6979    7253   +274     
=======================================
  Hits        21630   21630            
+ Misses         61      55     -6     
- Partials        0       6     +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 69125c2 into master Jun 5, 2024
6 checks passed
@ghiscoding ghiscoding deleted the bugfix/draggable-grouping-column-reorder branch June 5, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant