Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filters): Slider Filter left value should never be above left value #1590

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Jul 2, 2024

  • goes with previous commit 124cb96, right OR left value should never be above right OR left value a Slider Range filter

brave_RckLYaXsCd

- goes with previous commit, right OR left value should never be above right OR left value a Slider Range filter
Copy link

stackblitz bot commented Jul 2, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (124cb96) to head (4337300).

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1590     +/-   ##
========================================
+ Coverage    99.8%   99.8%   +0.1%     
========================================
  Files         198     198             
  Lines       21789   21793      +4     
  Branches     7157    7302    +145     
========================================
+ Hits        21728   21732      +4     
  Misses         55      55             
  Partials        6       6             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 3e165cf into master Jul 2, 2024
7 checks passed
@ghiscoding ghiscoding deleted the bugfix/min-max-slider branch July 2, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant