Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add collectionAsync option for both the Editors & Filters #16

Merged
merged 6 commits into from
Jul 18, 2020

Conversation

ghiscoding
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #16 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
+ Coverage   99.58%   99.58%   +0.01%     
==========================================
  Files         184      184              
  Lines        9897     9965      +68     
  Branches     3260     3392     +132     
==========================================
+ Hits         9855     9923      +68     
  Misses         42       42              
Impacted Files Coverage Δ
packages/common/src/filters/autoCompleteFilter.ts 100.00% <100.00%> (ø)
packages/common/src/filters/selectFilter.ts 100.00% <100.00%> (ø)
...bundle/src/components/slick-vanilla-grid-bundle.ts 92.75% <100.00%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebfd715...6aff3bd. Read the comment docs.

@ghiscoding ghiscoding changed the title feat: add collectionAsync option for both the Editors & Filters feat(core): add collectionAsync option for both the Editors & Filters Jul 17, 2020
@ghiscoding ghiscoding merged commit f9488ab into master Jul 18, 2020
@ghiscoding ghiscoding deleted the feat/collection-async branch July 18, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants