Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SlickCellExternalCopyManager should work w/hidden cols fixes #1634 #1651

Merged
merged 3 commits into from
Aug 24, 2024

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Aug 24, 2024

fixes #1634

  • prior to this PR, the hidden columns were being counted as column indexes when pasting and also when starting a cell selection

in the example below, the column C and D are hidden

brave_gC4wQ7pe3V

Copy link

stackblitz bot commented Aug 24, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Aug 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (559d7de) to head (7b48596).
Report is 14 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1651     +/-   ##
========================================
- Coverage    99.8%   99.8%   -0.0%     
========================================
  Files         199     199             
  Lines       21874   21882      +8     
  Branches     7176    7040    -136     
========================================
+ Hits        21811   21818      +7     
- Misses         57      64      +7     
+ Partials        6       0      -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 52e9805 into master Aug 24, 2024
6 checks passed
@ghiscoding ghiscoding deleted the bugfix/hidden-copy-cells branch August 24, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with enableExcelCopyBuffer and Hidden Columns Causing Selection Offset
1 participant