Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hideColumnByIds() should call setColumn() only once, fix #1728 #1736

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

ghiscoding
Copy link
Owner

fixes #1728

  • we should only ever call setColumn() once when hiding multiple columns to avoid perf issues
  • also add showColumnByIds() to align with hideColumnByIds()

- we should only ever call `setColumn()` once when hiding multiple columns to avoid perf issues
- also add `showColumnByIds()` to align with `hideColumnByIds()`
Copy link

stackblitz bot commented Nov 9, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@ghiscoding ghiscoding changed the title fix: hideColumnByIds() should call setColumn() only once fix: hideColumnByIds() should call setColumn() only once, fixes #1728 Nov 9, 2024
@ghiscoding ghiscoding changed the title fix: hideColumnByIds() should call setColumn() only once, fixes #1728 fix: hideColumnByIds() should call setColumn() only once, fix #1728 Nov 9, 2024
Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (976bd23) to head (95007db).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1736     +/-   ##
========================================
+ Coverage    99.8%   99.8%   +0.1%     
========================================
  Files         187     187             
  Lines       30733   30752     +19     
  Branches     9774    9777      +3     
========================================
+ Hits        30644   30663     +19     
  Misses         89      89             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 0ba1a93 into master Nov 9, 2024
8 checks passed
@ghiscoding ghiscoding deleted the bugfix/show-column-ids branch November 9, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HideColumnByIds performance
1 participant