Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pinning): recalculate frozen idx properly when column shown changes #241

Merged
merged 1 commit into from
Jan 22, 2021

Conversation

ghiscoding
Copy link
Owner

  • when using ColumnPicker, GridMenu or hiding a column via HeaderMenu, it has to recalculate the frozenColumn index because SlickGrid doesn't take care of that and the previous fix that I implement sometimes become out of sync. This PR simplifies the frozenColumn index position, it will simply update it when the index is different, as simple as that.

- when using ColumnPicker, GridMenu or hiding a column via HeaderMenu, it has to recalculate the frozenColumn index because SlickGrid doesn't take care of that and the previous fix that I implement sometimes become out of sync. This PR simplifies the frozenColumn index position, it will simply update it when the index is different, as simple as that.
@codecov
Copy link

codecov bot commented Jan 22, 2021

Codecov Report

Merging #241 (e143542) into master (f64ed37) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #241    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          207       207            
  Lines        11931     11933     +2     
  Branches      3945      4099   +154     
==========================================
+ Hits         11931     11933     +2     
Impacted Files Coverage Δ
...ges/common/src/extensions/columnPickerExtension.ts 100.00% <100.00%> (ø)
packages/common/src/extensions/extensionUtility.ts 100.00% <100.00%> (ø)
...ackages/common/src/extensions/gridMenuExtension.ts 100.00% <100.00%> (ø)
...kages/common/src/extensions/headerMenuExtension.ts 100.00% <100.00%> (ø)
packages/common/src/services/filter.service.ts 100.00% <0.00%> (ø)
...ing-component/src/slick-empty-warning.component.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f64ed37...e143542. Read the comment docs.

@ghiscoding ghiscoding merged commit 3b55972 into master Jan 22, 2021
@ghiscoding ghiscoding deleted the bugfix/frozen-picker-column-change branch January 22, 2021 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant