Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lerna): downgrade Lerna to previous version to fix thread leaking #281

Merged
merged 1 commit into from
Mar 6, 2021

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Mar 6, 2021

  • upgrading to latest version of Lerna 4.0.0 has a major side effect of NodeJS threads not being disposed after stopping the project
  • see Lerna issue #2841

- upgrading to latest version of Lerna 4.0.0 has a major side effect of NodeJS threads not being disposed after stopping the project
@codecov
Copy link

codecov bot commented Mar 6, 2021

Codecov Report

Merging #281 (99bb71f) into master (c6e9c3e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #281   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          209       209           
  Lines        12408     12408           
  Branches      4237      4237           
=========================================
  Hits         12408     12408           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6e9c3e...99bb71f. Read the comment docs.

@ghiscoding ghiscoding merged commit ffde71c into master Mar 6, 2021
@ghiscoding ghiscoding deleted the bugfix/lerna-leaking branch March 6, 2021 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant