Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filters): rollback a change made in PR #288 causing preset issues #295

Merged
merged 1 commit into from
Mar 23, 2021

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Mar 23, 2021

- rolling back this change since Aurelia-Slickgrid filter presets on Client Example was no longer working as expected
@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #295 (18ffc0c) into master (7111675) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #295   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          209       209           
  Lines        12486     12486           
  Branches      4279      4279           
=========================================
  Hits         12486     12486           
Impacted Files Coverage Δ
packages/common/src/services/filter.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7111675...18ffc0c. Read the comment docs.

@ghiscoding ghiscoding merged commit 960f0c7 into master Mar 23, 2021
@ghiscoding ghiscoding deleted the bugfix/filter-preset-operator branch March 23, 2021 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant