Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(services): add onBeforeResizeByContent (onAfter) #335

Merged
merged 1 commit into from
May 7, 2021

Conversation

ghiscoding
Copy link
Owner

  • if it takes time to read the entire dataset, we can use these events to show/hide a spinner when the process is over
  • another feat is that the onAfterResizeByContent will also return the calculated widths of each column as well and the number of rows that were analyzed

- if it takes time to read the entire dataset, we can use these events to show/hide a spinner when the process is over
- another feat is that the `onAfterResizeByContent` will also return the calculated widths of each column as well and the number of rows that were analyzed
@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #335 (3e99fab) into master (fecaaa1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #335   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          213       213           
  Lines        12992     12999    +7     
  Branches      4282      4282           
=========================================
+ Hits         12992     12999    +7     
Impacted Files Coverage Δ
...ges/vanilla-bundle/src/services/resizer.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fecaaa1...3e99fab. Read the comment docs.

@ghiscoding ghiscoding merged commit ec2ad6c into master May 7, 2021
@ghiscoding ghiscoding deleted the feat/resize-by-content-events branch May 7, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant