fix(demo): we should be able to move row(s) and keep selections #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ghiscoding
commented
May 26, 2021
•
ghiscoding
commented
- grid state should only be allowed to change row selection only when Pagination is enabled
- refactor some part of the code to use more optional chaining (?.) syntax for cleaner and smaller code
- move around some of the Cypress tests so that it makes sure that moving rows will keep row selections
- grid state should only be allowed to change row selection only when Pagination is enabled - refactor some part of the code to use more optional chaining (?.) syntax for cleaner and smaller code - move around some of the Cypress tests so that it makes sure that moving rows will keep selections
Codecov Report
@@ Coverage Diff @@
## master #352 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 212 212
Lines 13241 13230 -11
Branches 4340 4337 -3
=========================================
- Hits 13241 13230 -11
Continue to review full report at Codecov.
|
AnnetteZhang
requested changes
May 26, 2021
| @@ -258,9 +258,9 @@ export class GridStateService { | |||
| */ | |||
| getCurrentPagination(): CurrentPagination | null { | |||
| if (this._gridOptions.enablePagination) { | |||
There was a problem hiding this comment.
looks like _gridOptions can be null sometimes. If you check null on line 260 with "?.", you can remove the "?." on line 261.
AnnetteZhang
approved these changes
May 26, 2021
ghiscoding-SE
pushed a commit
that referenced
this pull request
May 28, 2021
- previous PR #352 that fixed row selection with row move actually caused a regression with toggling of pagination, when removing Pagination on the fly it will show all items in the grid and there is code in the Grid State Service that will take row selections from all page and reselect them when we toggle to No Pagination, and we need to change our `enablePagination` only after that Grid State Service is finished else we end up missing row selection from all other pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.